Fix ConcatReader.close() to close all readers on failure#490
Merged
SuperMonster003 merged 1 commit intoSuperMonster003:masterfrom Mar 14, 2026
Merged
Fix ConcatReader.close() to close all readers on failure#490SuperMonster003 merged 1 commit intoSuperMonster003:masterfrom
SuperMonster003 merged 1 commit intoSuperMonster003:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
ConcatReader.close()exception-safe in bothcom.stardust.io.ConcatReaderandorg.autojs.autojs.io.ConcatReader.Problem
If closing one underlying
Readerthrows anIOException,close()exits early and the remaining readers are never closed.Fix
Close all readers in the queue, collect the first
IOException, suppress subsequent close failures, and throw after cleanup is complete.